Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't run hook if help text option is provided #5863

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

mildaniel
Copy link
Contributor

@mildaniel mildaniel commented Aug 29, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

There is a bug where the hook package is executed even if the customer provides a help text flag.

How does it address the issue?

Add an additional condition to avoid running the hook if the help text option is provided.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner August 29, 2023 23:33
@mildaniel mildaniel requested review from sriram-mv and hawflau August 29, 2023 23:33
@mildaniel mildaniel added this pull request to the merge queue Aug 30, 2023
Merged via the queue into aws:develop with commit c1b1664 Aug 30, 2023
76 checks passed
@mildaniel mildaniel deleted the fix-hook-help-text branch August 30, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants